[ 
https://issues.apache.org/jira/browse/PDFBOX-6032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18004606#comment-18004606
 ] 

Andreas Lehmkühler commented on PDFBOX-6032:
--------------------------------------------

I like the idea of a functional interface but I don't like the name. The 
current implementation uses the LosslessFactory for bmp and gif on a regular 
basis. The fallback scenario is limited to tiffs which can't be read. Maybe 
something like DefaultFactory or similar would be better

> Issues encountered while customizing "PDImageXObject"
> ------------------------------------------------------
>
>                 Key: PDFBOX-6032
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-6032
>             Project: PDFBox
>          Issue Type: Wish
>          Components: PDModel
>    Affects Versions: 3.0.5 PDFBox
>            Reporter: Ilgoo Kim
>            Priority: Major
>
> In my team, we are using PDFBox to add an PDF-export feature to our editor 
> service.
> Unfortunately the performance does not meet our expectations, especially 
> when LosslessFactory is invoked within the "createFromByteArray" function of 
> PDImageXObject.
> Therefore we customized the "createFromByteArray" function to favor 
> JPEGFactory over LosslessFactory in order to improve performance, even at the 
> cost of some image quality loss. (based on the criteria through a 
> pixel-by-pixel alpha check)
> However, bringing the "createFromByteArray" function into our project 
> introduces a problem: since "PNGConverter" is not public, we are forced to 
> copy the entire "PNGConverter" class into our codebase as well.
> I was wondering if it would be possible to make the "PNGConverter" class 
> public, or alternatively, if there is a recommended way to better customize 
> the "createFromByteArray" function.
> Thank you.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Reply via email to