[
https://issues.apache.org/jira/browse/PDFBOX-6032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18003772#comment-18003772
]
Tilman Hausherr commented on PDFBOX-6032:
-----------------------------------------
We usually try not to expose to much things. OTOH just making the class "public
final" and exposing the method wouldn't hurt too much, it's just the behavior
that is unusual.
Alternatively maybe an extra {{createFromByteArray}} method that tells what
encoding to use as fallback? (is your current customizing that you use JPEG
encoding when PNGConverter fails?)
> Issues encountered while customizing "PDImageXObject"
> ------------------------------------------------------
>
> Key: PDFBOX-6032
> URL: https://issues.apache.org/jira/browse/PDFBOX-6032
> Project: PDFBox
> Issue Type: Wish
> Components: PDModel
> Affects Versions: 3.0.5 PDFBox
> Reporter: Ilgoo Kim
> Priority: Major
>
> In my team, we are using PDFBox to add an PDF-export feature to our editor
> service.
> Unfortunately the performance does not meet our expectations, especially
> when LosslessFactory is invoked within the "createFromByteArray" function of
> PDImageXObject.
> Therefore we customized the "createFromByteArray" function to favor
> JPEGFactory over LosslessFactory in order to improve performance, even at the
> cost of some image quality loss. (based on the criteria through a
> pixel-by-pixel alpha check)
> However, bringing the "createFromByteArray" function into our project
> introduces a problem: since "PNGConverter" is not public, we are forced to
> copy the entire "PNGConverter" class into our codebase as well.
> I was wondering if it would be possible to make the "PNGConverter" class
> public, or alternatively, if there is a recommended way to better customize
> the "createFromByteArray" function.
> Thank you.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org
