On Tue, Sep 27, 2016 at 03:46:04PM +0300, Paul Blakey wrote: > Add tc ingress qdisc support so we can add qdisc > as a qos on port or through config. > usage: > ovs-vsctl -- set port <PORT> qos=@newq -- --id=@newq create \ > qos type=linux-ingress > where <PORT> is a already added port using vsctl add-port. > > Signed-off-by: Paul Blakey <pa...@mellanox.com> > Signed-off-by: Shahar Klein <shah...@mellanox.com>
I don't plan to review all of these patches but this one caught my eye. I think that the ingress qdisc is different from the other qdiscs, in that it is not an alternative to the others but can be used at the same time as any other qdisc. It affects how packets are treated when they are received, rather than how they are treated as they are sent. That's why OVS already supports the ingress qdisc, through the ingress_policing_rate and ingress_policing_burst settings in the Interface table. Therefore, I think that this patch should be dropped. Thanks, Ben. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
