On Fri, Jul 29, 2016 at 12:29:16PM -0500, Justin Pettit wrote: > > > On Jul 29, 2016, at 11:58 AM, Ben Pfaff <b...@ovn.org> wrote: > > > >> On Thu, Jul 28, 2016 at 11:26:15PM -0700, Justin Pettit wrote: > >> Suggested-by: Ben Pfaff <b...@ovn.org> > >> Signed-off-by: Justin Pettit <jpet...@ovn.org> > > > >> + ovs_be32 bcast = addr | ~na->mask; > >> + inet_ntop(AF_INET, &addr, na->addr_s, INET_ADDRSTRLEN); > >> + inet_ntop(AF_INET, &na->network, na->network_s, INET_ADDRSTRLEN); > >> + inet_ntop(AF_INET, &bcast, na->bcast_s, INET_ADDRSTRLEN); > > > > I'd use sizeof na->addr_s (etc.) above, instead of INET_ADDRSTRLEN. > > > >> } > >> > >> static void > >> @@ -55,11 +56,8 @@ add_ipv6_netaddr(struct lport_addresses *laddrs, struct > >> in6_addr addr, > >> na->plen = plen; > >> in6_addr_solicited_node(&na->sn_addr, &addr); > >> > >> - na->addr_s = xmalloc(INET6_ADDRSTRLEN); > >> inet_ntop(AF_INET6, &addr, na->addr_s, INET6_ADDRSTRLEN); > >> - na->sn_addr_s = xmalloc(INET6_ADDRSTRLEN); > >> inet_ntop(AF_INET6, &na->sn_addr, na->sn_addr_s, INET6_ADDRSTRLEN); > >> - na->network_s = xmalloc(INET6_ADDRSTRLEN); > >> inet_ntop(AF_INET6, &na->network, na->network_s, INET6_ADDRSTRLEN); > > > > Similarly here. > > Will do. Did you want to see a revision or are you okay acking it?
I thought I'd acked it. Acked-by: Ben Pfaff <b...@ovn.org> _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
