On Thu, Jul 28, 2016 at 11:26:12PM -0700, Justin Pettit wrote: > Rename "compose_nd" and "compose_na" to "compose_nd_ns" and > "compose_nd_na", respecively, to be clearer about their functionality. > This will also make it more consistent when we add Neighbor Discover > Router Solicitation/Advertisement compose functions. > > Also change the source and destination IPv6 addresses to take > "struct in6_addr" arguments, which are more common in the code base. > > Signed-off-by: Justin Pettit <jpet...@ovn.org> > > --- > v1->v2: Renamed functions to be consistent when adding more ND messages. > Fix alignment issues introduced with taking "struct in6_addr".
I don't think that the ALIGNED_CASTs in compose_nd_ns() and compose_nd_na() are necessarily safe, on a system that lacks s6_addr32. Other than that, Acked-by: Ben Pfaff <b...@ovn.org> Thanks, Ben. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
