On Wed, May 04, 2016 at 04:34:25PM +0900, Simon Horman wrote: > Add support for layer 3 GRE vports (non-tap aka non-VTEP). > > This makes use of a vport mode configuration for the existing (tap/VTEP) > GRE vports. > > In order to differentiate packets for two different types of GRE vports a > new flow key attribute, OVS_KEY_ATTR_NEXT_BASE_LAYER, is used. It is > intended that this attribute is only used in userspace as there appears to > be no need for it to be used in the kernel datapath.
Should the OVS_KEY_ATTR_NEXT_BASE_LAYER declaration in an #ifndef __KERNEL__ block or similar? At least a comment on the declaration would be helpful. > It is envisaged that this attribute may be used for other encapsulation > protocols that support both layer3 and layer2 inner-packets. > > Signed-off-by: Simon Horman <simon.hor...@netronome.com> miniflow_extract() has some tabs that should be spaces for indentation. There's a change to tnl_port_show() to "Skip ports with duplicate 'port' field". I don't understand this change. Can you explain it? (It's O(n**2) in the number of ports, too.) In vswitch.xml, there's a couple of typos: s/recieved/received/ and s/ethernet/Ethernet/. Thanks, Ben. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
