Thanks for the reminder Ben and sorry for the delay. I think this just fixes a warning at the end of the DPDK compilation, right?
In any case, I prefer the version Flavio suggested, which should be equivalent for the current OVS+DPDK build process. Thanks On 29/02/2016 10:22, "Ben Pfaff" <b...@ovn.org> wrote: >Daniele, have you taken a look at this patch? > >On Mon, Feb 22, 2016 at 01:49:54PM -0300, Flavio Leitner wrote: >> >> Adding Daniele just in case. >> >> fbl >> >> On Mon, 22 Feb 2016 10:13:10 +0000 >> "Weglicki, MichalX" <michalx.wegli...@intel.com> wrote: >> >> > Hello, >> > >> > Just gentle reminder, is this patch fine? Or I'm supposed to correct >>something? >> > >> > As Flavio mentioned it is important change for 2.5 branch. >> > >> > Br, >> > Michal. >> > >> > -----Original Message----- >> > From: Flavio Leitner [mailto:f...@sysclose.org] >> > Sent: Friday, February 12, 2016 1:18 AM >> > To: Weglicki, MichalX <michalx.wegli...@intel.com> >> > Cc: dev@openvswitch.org; Daniele Di Proietto <diproiet...@vmware.com> >> > Subject: Re: [ovs-dev] [PATCH] Installation steps correction for DPDK >>2.2. >> > >> > On Fri, 5 Feb 2016 11:42:06 +0000 >> > mweglicx <michalx.wegli...@intel.com> wrote: >> > >> > > Missing step added to INSTALL.DPDK.md which prevents >> > > installation error message. >> > > >> > > Signed-off-by: Michal Weglicki <michalx.wegli...@intel.com> >> > > --- >> > > INSTALL.DPDK.md | 20 ++++++++++---------- >> > > 1 file changed, 10 insertions(+), 10 deletions(-) >> > > >> > > diff --git a/INSTALL.DPDK.md b/INSTALL.DPDK.md >> > > index c601358..0928e66 100644 >> > > --- a/INSTALL.DPDK.md >> > > +++ b/INSTALL.DPDK.md >> > > @@ -33,14 +33,22 @@ on Debian/Ubuntu) >> > > >> > > `CONFIG_RTE_BUILD_COMBINE_LIBS=y` >> > > >> > > + * Non IVSHMEM: >> > > + >> > > + `export DPDK_BUILD=$DPDK_DIR/x86_64-native-linuxapp-gcc` >> > > + >> > > + * IVSHMEM: >> > > + >> > > + `export DPDK_BUILD=$DPDK_DIR/x86_64-ivshmem-linuxapp-gcc` >> > > + >> > > Then run `make install` to build and install the library. >> > > For default install without IVSHMEM: >> > > >> > > - `make install T=x86_64-native-linuxapp-gcc` >> > > + `make install T=x86_64-native-linuxapp-gcc >>DESTDIR=$DPDK_BUILD/install` >> > > >> > > To include IVSHMEM (shared memory): >> > > ake install T=x86_64-ivs >> > > - `make install T=x86_64-ivshmem-linuxapp-gcc` >> > > + `make install T=x86_64-ivshmem-linuxapp-gcc >>DESTDIR=$DPDK_BUILD/install` >> > > >> > > For further details refer to http://dpdk.org/ >> > > >> > > @@ -51,14 +59,6 @@ on Debian/Ubuntu) >> > > >> > > 3. Configure & build OVS: >> > > >> > > - * Non IVSHMEM: >> > > - >> > > - `export DPDK_BUILD=$DPDK_DIR/x86_64-native-linuxapp-gcc/` >> > > - >> > > - * IVSHMEM: >> > > - >> > > - `export DPDK_BUILD=$DPDK_DIR/x86_64-ivshmem-linuxapp-gcc/` >> > > - >> > > ``` >> > > cd $(OVS_DIR)/ >> > > ./boot.sh >> > >> > The real change is just the addition of DESTDIR argument which could >> > have been, for example: >> > make install T=x86_64-ivshmem-linuxapp-gcc DESTDIR=install >> > >> > Anyway, the doc looks good after the patch. >> > >> > Acked-by: Flavio Leitner <f...@sysclose.org> >> > >> > BTW, this needs to go in branch-2.5 as well. >> > >> >> >> _______________________________________________ >> dev mailing list >> dev@openvswitch.org >> http://openvswitch.org/mailman/listinfo/dev _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
