Hello, Just gentle reminder, is this patch fine? Or I'm supposed to correct something?
As Flavio mentioned it is important change for 2.5 branch. Br, Michal. -----Original Message----- From: Flavio Leitner [mailto:f...@sysclose.org] Sent: Friday, February 12, 2016 1:18 AM To: Weglicki, MichalX <michalx.wegli...@intel.com> Cc: dev@openvswitch.org; Daniele Di Proietto <diproiet...@vmware.com> Subject: Re: [ovs-dev] [PATCH] Installation steps correction for DPDK 2.2. On Fri, 5 Feb 2016 11:42:06 +0000 mweglicx <michalx.wegli...@intel.com> wrote: > Missing step added to INSTALL.DPDK.md which prevents > installation error message. > > Signed-off-by: Michal Weglicki <michalx.wegli...@intel.com> > --- > INSTALL.DPDK.md | 20 ++++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/INSTALL.DPDK.md b/INSTALL.DPDK.md > index c601358..0928e66 100644 > --- a/INSTALL.DPDK.md > +++ b/INSTALL.DPDK.md > @@ -33,14 +33,22 @@ on Debian/Ubuntu) > > `CONFIG_RTE_BUILD_COMBINE_LIBS=y` > > + * Non IVSHMEM: > + > + `export DPDK_BUILD=$DPDK_DIR/x86_64-native-linuxapp-gcc` > + > + * IVSHMEM: > + > + `export DPDK_BUILD=$DPDK_DIR/x86_64-ivshmem-linuxapp-gcc` > + > Then run `make install` to build and install the library. > For default install without IVSHMEM: > > - `make install T=x86_64-native-linuxapp-gcc` > + `make install T=x86_64-native-linuxapp-gcc DESTDIR=$DPDK_BUILD/install` > > To include IVSHMEM (shared memory): > ake install T=x86_64-ivs > - `make install T=x86_64-ivshmem-linuxapp-gcc` > + `make install T=x86_64-ivshmem-linuxapp-gcc DESTDIR=$DPDK_BUILD/install` > > For further details refer to http://dpdk.org/ > > @@ -51,14 +59,6 @@ on Debian/Ubuntu) > > 3. Configure & build OVS: > > - * Non IVSHMEM: > - > - `export DPDK_BUILD=$DPDK_DIR/x86_64-native-linuxapp-gcc/` > - > - * IVSHMEM: > - > - `export DPDK_BUILD=$DPDK_DIR/x86_64-ivshmem-linuxapp-gcc/` > - > ``` > cd $(OVS_DIR)/ > ./boot.sh The real change is just the addition of DESTDIR argument which could have been, for example: make install T=x86_64-ivshmem-linuxapp-gcc DESTDIR=install Anyway, the doc looks good after the patch. Acked-by: Flavio Leitner <f...@sysclose.org> BTW, this needs to go in branch-2.5 as well. -- fbl -------------------------------------------------------------- Intel Research and Development Ireland Limited Registered in Ireland Registered Office: Collinstown Industrial Park, Leixlip, County Kildare Registered Number: 308263 This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
