On Wed, Feb 17, 2016 at 11:45:29AM -0800, Jarno Rajahalme wrote:
> So far we have been limited to including only one MPLS label in the
> textual datapath flow format.  Allow upto 3 labels to be included so
> that testing with multiple labels becomes easier.
> 
> Signed-off-by: Jarno Rajahalme <ja...@ovn.org>

Why 3 instead of FLOW_MAX_MPLS_LABELS?

My previous thought was to include multiple labels in a more compact
form by writing the LSEs in hex, as was previously done for n > 1 in
format_mpls_lse().  I guess this form is more user-friendly.

The approach of just including more than one of each key had simply not
occurred to me.  I would have probably added some additional wrapper,
e.g. mpls(lse0(label=...),lse1(label=...)).  Maybe there is no benefit
to that.

Acked-by: Ben Pfaff <b...@ovn.org>
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to