Current testing guidelines do not take account of two distinct OVS builds: a) 'standard' OVS b) OVS with DPDK integration
It is critical that all patches are tested against both builds; if not, there is a strong possibility that code which adversely affects one of the builds may be upstreamed, leading to issues such as broken build, e.g. http://openvswitch.org/pipermail/dev/2016-January/064328.html Signed-off-by: Mark Kavanagh <mark.b.kavan...@intel.com> --- CONTRIBUTING.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 086b6e8..fe9400a 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -35,6 +35,9 @@ Testing is also important: - A patch that adds or deletes files should also be tested with `make distcheck` before submission. + - The above tests should be performed with OVS compiled as 'normal', + and also compiled with DPDK support. + - A patch that modifies Linux kernel code should be at least build-tested on various Linux kernel versions before submission. I suggest versions 2.6.32 and whatever -- 1.9.3 _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
