On Wed, Jan 20, 2016 at 05:33:16PM -0500, Russell Bryant wrote: > While debugging a broken OVN environment yesterday, the problem turned > out to be invalid entries in the logical port addresses column. In > particular, the following command had been used: > > $ ovn-nbctl lport-set-addresses lp0 MAC IP > > instead of: > > $ ovn-nbctl lport-set-addresses lp0 "MAC IP" > > This is really easy to mess up, so add some simple validation to the > lport-set-addresses command. If the beginning of an argument is ever > an IP address, it's wrong. > > In passing, also add a note to the ovn-nb db documentation to note that > the order of "MAC IP" is required, as "IP MAC" is not valid. > > Signed-off-by: Russell Bryant <russ...@ovn.org>
Indentation in the "if" condition looks a little weird, please check it. Acked-by: Ben Pfaff <b...@ovn.org> _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
