On Thu, Nov 26, 2015 at 06:41:30PM +0900, YAMAMOTO Takashi wrote:
> While (surprisingly to me) bash interprets $10 as ${1}0,
> many other shells, including NetBSD's /bin/sh, interpret it as ${10}.
The code-changes look fine to me but I wonder if the changelog could
be made a bit clearer. Something like:
ovn.at: Use {} to make variable expansion less ambiguous
While (surprisingly to me) bash interprets $10 as ${1}0,
many other shells, including NetBSD's /bin/sh, interpret it as ${10}.
Also use already assigned named variables rather than positional
parameters to make things a little more readable.
>
> Signed-off-by: YAMAMOTO Takashi <yamam...@midokura.com>
> ---
> tests/ovn.at | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/ovn.at b/tests/ovn.at
> index 68fcc9a..de0a830 100644
> --- a/tests/ovn.at
> +++ b/tests/ovn.at
> @@ -964,7 +964,7 @@ done
> test_ip() {
> # This packet has bad checksums but logical L3 routing doesn't check.
> local inport=$1 src_mac=$2 dst_mac=$3 src_ip=$4 dst_ip=$5
> - local packet=$3$208004500001c0000000040110000$4$50035111100080000
> + local
> packet=${dst_mac}${src_mac}08004500001c0000000040110000${src_ip}${dst_ip}0035111100080000
> shift; shift; shift; shift; shift
> hv=hv`vif_to_hv $inport`
> as $hv ovs-appctl netdev-dummy/receive vif$inport $packet
> --
> 2.4.9 (Apple Git-60)
>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
