On Tue, Sep 22, 2015 at 05:51:11PM -0700, Andy Zhou wrote:
> OVS daemons can now support --user option to run as a non-root
> user with less privileges.
> 
> See the manpage patch for more descriptions.
> 
> Signed-off-by: Andy Zhou <az...@nicira.com>

...

> +void
> +dameon_become_new_user(bool access_datapath OVS_UNUSED)

s/dameon/daemon/ above.

> +.IP
> +On Windows, this option is not currently supported. For security reasons,
> +Specifying this option will cause the daemon process not to start.

s/Specifying/specifying/ above.

There's a change to the comment on read_pidfile() that looks like a
typo.

I'm not really sure why the caller of daemon_become_new_user() needs to
check the OS type to decide on 'access_datapath' and then
daemon_become_new_user() verifies that it's correct for the OS.  I would
guess that it could just be hardcoded for the caller (e.g. always "true"
for ovs-vswitchd) and then daemon_become_new_user() only needs to do
anything special if it's running on Linux.

Acked-by: Ben Pfaff <b...@nicira.com>

_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to