On 13 September 2015 at 12:15, Justin Pettit <jpet...@nicira.com> wrote:
> Go through ovn-sb to see what is also set by ovn-controller-vtep. For > example, the "chassis" column in the Port_Binding record. > > Done, thx for the reminder~! > > > On Aug 27, 2015, at 11:21 PM, Alex Wang <ee07b...@gmail.com> wrote: > > > > > > > + table entry, and bind particular vlan on VTEP gateway's port to > > + any VTEP logical switch. Once a VTEP logical switch is bound to > > + a VTEP gateway, the <code>ovn-controller-vtep</code> will detect > > + it and add its name to the <var>vtep_logical_switches</var> > > I mention it again later, but there's some inconsistency between > underscores and hyphens in these key names. I think it would be better to > just go with hyphens. > > For this 'vtep_logcial_switches', I follow the column name defined in schema, which should be fine. For the options, vtep-pswitch-name, and vtep-lswitch-name, I will make sure hyphen is used in documentation. > > > + Next, the <code>ovn-controller-vtep</code> will keep reacting to > the > > + <code>Port_Binding</code> table and the > <code>Multicast_Group</code> > > + table configuration change in the <code>OVN_Northbound</code> > database, > > + and updating the <code>Ucast_Macs_Remote</code> table and the > <code> > > + Mcast_Macs_Remote</code> table in the <code>VTEP</code> database, > > The code doesn't actually do all of this, right? I think that might be > confusing to users--even if it's documented in the TODO list. > > I see, then, let me drop all the un-implemented features. > > > + forward the traffic coming from the extended external network. > > + </li> > > + > > + <li> > > + Eventually, the VTEP gateway's life cycle ends when the > administrator > > + unregisters the VTEP gateway from the <code>VTEP</code> database. > > + The <code>ovn-controller-vtep</code> will recognized the event and > > + remove all related configurations in the > <code>OVN_Southbound</code> > > + database. > > + </li> > > Is it worth mentioning the cleanup that occurs when a VTEP is removed from > ovn-nb? > > Yeah, I'll do that, > > diff --git a/ovn/ovn-nb.xml b/ovn/ovn-nb.xml > > index ade8164..5bb9265 100644 > > --- a/ovn/ovn-nb.xml > > +++ b/ovn/ovn-nb.xml > > @@ -111,18 +111,37 @@ > > <column name="type"> > > <p> > > Specify a type for this logical port. Logical ports can be used > to model > > - other types of connectivity into an OVN logical switch. Leaving > this column > > - blank maintains the default logical port behavior. > > + other types of connectivity into an OVN logical switch. Leaving > this > > + column blank maintains the default logical port behavior, which is > > + for a VM (or VIF) interface. Besides, the following types are > > + defined: > > I think it might be clearer to write this sentence as "The following other > types are defined:" > > Adopted, > > </p> > > > > - <p> > > - There are no other logical port types implemented yet. > > - </p> > > + <dl> > > + <dt><code>vtep</code></dt> > > + <dd>A port to a logical switch on a VTEP gateway. In order > > + to get this port correctly recognized by the ovn controller, the > > In the documentation, we've been using all caps for "OVN". > Fixed, > > > + <ref column="options" > table="Logical_Port"/>:vtep_physical_switch > > + and <ref column="options" > table="Logical_Port"/>:vtep_logical_switch > > + must also be defined.</dd> > > + </dl> > > Since you've written this, "localnet" has been added, so that will need to > be reworked into a bullet point. > > Yeah, I made the change during rebase > > <column name="options"> > > + <p> > > This column provides key/value settings specific to the logical > port > > - <ref column="type"/>. > > + <ref column="type"/>. The following options are defined: > > + </p> > > + > > + <dl> > > + <dt><code>vtep_physical_switch</code></dt> > > + <dd>The name of the VTEP gateway.</dd> > > I think it would be helpful to indicate if this is only meaningful if the > "type" is "vtep". > > Added during rebase, > > + <dt><code>vtep_logical_switch</code></dt> > > + <dd>A logical switch name connected by the VTEP gateway.</dd> > > Ditto. > > > --- a/ovn/ovn-sb.xml > > +++ b/ovn/ovn-sb.xml > > @@ -172,7 +172,13 @@ > > > > <column name="vtep_logical_switches"> > > Stores all vtep logical switch names connected by this gateway > > - chassis. > > + chassis. The <ref table="Port_Binding"/> table entry with > > + <ref column="options" > table="Port_Binding"/>:vtep_physical_switch > > + equal <ref table="Chassis"/> <ref column="name" > table="Chassis"/>, > > + and <ref column="options" > table="Port_Binding"/>:vtep_logical_switch > > + value in <ref table="Chassis"/> > > + <ref column="vtep_logical_switches" table="Chassis"/>, will be > > + associated with this <ref table="Chassis"/>. > > These (and other places in the documentation) are using underscores, but > the code and error messages in the code use hyphens. I'd just go with > hyphens to be more consistent. > > Yeah, sorry for the careless documentation, will keep it consistent, > > @@ -894,18 +900,39 @@ > > <column name="type"> > > <p> > > A type for this logical port. Logical ports can be used to model > > - other types of connectivity into an OVN logical switch. Leaving > this column > > - blank maintains the default logical port behavior. > > + other types of connectivity into an OVN logical switch. Leaving > this > > + column blank maintains the default logical port behavior, which > > + is for a VM (or VIF) interface. Besides, the following types are > > + defined: > > I think it might be clearer to write this sentence as "The following other > types are defined:" > > > > > + <dt><code>vtep</code></dt> > > + <dd>A port to a logical switch on a VTEP gateway chassis. In > order > > + to get this port correctly recognized by the ovn controller, the > > + <ref column="options" > table="Port_Binding"/>:vtep_physical_switch > > + and <ref column="options" > table="Port_Binding"/>:vtep_logical_switch > > + must also be defined.</dd> > > + </dl> > > </column> > > I think "localnet" support has been added now, so that will need to be > updated to the bullet-point form that you have above. > > > <column name="options"> > > + <p> > > This column provides key/value settings specific to the logical > port > > - <ref column="type"/>. > > + <ref column="type"/>. The following options are defined: > > Same issue here about "localnet" being added. > > > + </p> > > + > > + <dl> > > + <dt><code>vtep_physical_switch</code></dt> > > + <dd>The <ref column="name" table="Chassis"/> of the VTEP gateway > > + chassis.</dd> > > I think it would be helpful to indicate if this is only meaningful if the > "type" is "vtep". > > > + <dt><code>vtep_logical_switch</code></dt> > > + <dd>A logical switch name in VTEP gateway chassis's > > + <ref column="vtep_logical_switches" table="Chassis"/>.</dd> > > Ditto. > > --Justin > > > -- Alex Wang, Open vSwitch developer _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
