> On Sep 13, 2015, at 12:19 PM, ALeX Wang <ee07b...@gmail.com> wrote:
> 
> 
> 
> On 13 September 2015 at 10:45, Justin Pettit <jpet...@nicira.com> wrote:
> 
> > On Aug 27, 2015, at 11:21 PM, Alex Wang <ee07b...@gmail.com> wrote:
> >
> > +    /* Collects 'Ucast_Macs_Remote's. */
> > +    VTEPREC_UCAST_MACS_REMOTE_FOR_EACH (umr, ctx->vtep_idl) {
> > +        char *mac_ip =
> > +            xasprintf("%s%s", umr->MAC,
> > +                     umr->locator ? umr->locator->dst_ip : "");
> 
> xxx Surprised there's no delimiter.
> 
> 
> is that a convention?  since I only need it for hash, just put them all 
> together,

Sorry.  That was a note to myself, but forgot to clean it up.  It's fine for 
this version.  However, if you add a tunnel key, it might be good to add a 
delimiter, since IP addresses and tunnel keys are variable length, and you 
could run into a collision.

--Justin


_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to