On Wed, Aug 26, 2015 at 04:29:50PM -0700, Andy Zhou wrote: > This is not a review, since I am not that familiar with this code yet. > Just a few questions > > Should compare_cmps_3way() be of type 'int' instead of bool?
Yes, thanks, fixed. > Should crash_or() also make use of disjunction_matches_string() in > case of string? No, it's a different case. > On Tue, Aug 25, 2015 at 9:37 PM, Ben Pfaff <b...@nicira.com> wrote: > > The expr test cases covered string variables poorly and thus a number of > > bugs and omissions slipped through. This fixes them and generalizes the > > test cases to better cover string variables. > > > > Reported-by: Justin Pettit <jpet...@nicira.com> > > Signed-off-by: Ben Pfaff <b...@nicira.com> [...] Thanks, Ben. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
