> On Aug 25, 2015, at 9:37 PM, Ben Pfaff <b...@nicira.com> wrote: > > +/* Implementation of crush_cmps() for expr->type == EXPR_T_OR. */ > static struct expr * > crush_or(struct expr *expr, const struct expr_symbol *symbol)
Since you added this for crush_or(), do you want to do the same for crush_and(). > -/* Converts 'expr', which must be a cmp in the sense determined by > - * expr_is_cmp(). Returns a cmp, a disjunction of cmps, or a boolean. */ > +/* Takes ownership of 'expr', which must be a cmp in the sense determined by > + * expr_is_cmp(), and returns an equivalent expression owned by the caller > that > + * is a single EXPR_T_CMP or a disjunction of them or a EXPR_T_BOOLEAN. > + * > + * 'symbol' must be expr_is_cmp(expr). */ I'm not sure I understand this last sentence. Acked-by: Justin Pettit <jpet...@nicira.com> --Justin _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
