On Thu, Mar 19, 2015 at 12:08:16AM -0700, Andy Zhou wrote: > This patch set implements two ideas improve ovsdb connection scaling: > > * Allow multiple jsonrpc connection to share a single ovsdb monitor, thus > maintaining a single set of changes. > > * With in the same monitor, cache the json object generated for an update. > If the same update is requested by another jsonrpc connection, the > cached json object can be used, avoid regenerating it from scratch.
This series is nice, but it adds a lot of complication. That's fine, there's a lot of potential payoff, but I doubt that the existing testsuite really tests any of the new cases. Before this goes in I'd really like to see some new tests that add some confidence regarding correctness. Do you have an idea of how to test the new cases? Also, have you tried running the existing ovsdb tests, or a subset of them, under valgrind? e.g. "make check-valgrind" with appropriate TESTSUITEFLAGS to run tests of interest? That would be likely to find low-hanging memory leaks and memory use errors that can easily crop up even in very carefully written code (be sure to look at the valgrind logs it produces). _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
