On Thu, Mar 19, 2015 at 12:08:41AM -0700, Andy Zhou wrote: > Store ovsdb monitor in global hmap. A newly created ovsdb monitor > object will first search the global hmap for a possible match. If > one is found, the existing ovsdb monitor is used instead. > > With this patch, jsonrpc monitor and ovsdb monitor now have N:1 mapping. > > Signed-off-by: Andy Zhou <az...@nicira.com>
Probably best to statically initialize this, with HMAP_INITIALIZER: > +static struct hmap ovsdb_monitors; rather than to initialize it only on first use. I'm not sure why ovsdb_monitor_add() uses hmap_insert_fast() instead of plain hmap_insert(). In ovsdb_jsonrpc_monitor_create(), s/exsiting/existing/: + /* Found an exsiting dbmon, reuse the current one. */ and a few lines later there's a missing space: + m->dbmon =dbmon; Acked-by: Ben Pfaff <b...@nicira.com> _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
