> -----Original Message----- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Traynor, > Kevin > Sent: Monday, March 16, 2015 6:46 PM
[snip] > > > > > > Hi, I've reviewed this patchset - few comments/questions on it… > > > > Hi Kevin, thanks > > > > > I haven't tested yet - but I'm wondering what is the impact to the > > > dpdk -c parameter. Is it no longer used for OVS? > > > > > > > Yes, that’s correct. It should have no impact on OVS. I think we > > should also provide a default, i.e. generate the parameters passed to > > dpdk_eal_init at some point. +1 to removing the -c parameter as it seems to be the same as 'other_config:n-pmd-cores' and is a little confusing as to how they interact. Maybe 'other_config:n-pmd-cores' could be a mandatory option? > > > > > At present the NON_PMD_CORE_ID define overrides the db settings > > > (which is clearly documented). Is it needed now that a db key is > > > available? Perhaps it would make things simpler that the define is > > > overridden when a key is specified? > > > > > > > We check NON_PMD_CORE_ID often in the fast path. I would prefer > > leaving it as it is right now and removing this limitation later, > > making sure that it has no impact on performance. > > Sounds fine to me. > > _______________________________________________ > dev mailing list > dev@openvswitch.org > http://openvswitch.org/mailman/listinfo/dev _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
