On Oct 16, 2014, at 2:09 PM, Jarno Rajahalme <jrajaha...@nicira.com> wrote:
> Thanks for the reviews, Alex!
>
> On Oct 14, 2014, at 3:31 PM, Alex Wang <al...@nicira.com> wrote:
>>
>> +/* Insert 'rule' into 'cls'. */
>> +static void
>> +dpcls_insert(struct dpcls *cls, struct dpcls_rule *rule,
>> + const struct netdev_flow_key *mask)
>> +{
>> + struct dpcls_subtable *subtable = dpcls_find_subtable(cls, mask);
>> +
>> + rule->mask = &subtable->mask;
>> + cmap_insert(&subtable->rules, &rule->cmap_node, rule->flow.hash);
>> +}
>> +
>>
>> Could we add thread-safety tags to these dpctl_*()?
>>
>
> OK
>
I have to take this back, adding thread safety annotations requires the
addition of ‘dp’ parameter (for 'dp->mutex’), which would need to change as
soon as we move the classifier to pmd threads.
> Jarno
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
