Thanks for the reviews, Alex!
On Oct 14, 2014, at 3:31 PM, Alex Wang <[email protected]> wrote:
> static inline struct netdev_flow_key *
> -miniflow_to_netdev_flow_key(const struct miniflow *mf)
> +miniflow_to_netdev_flow_key(const struct miniflow *miniflow)
> {
> - return (struct netdev_flow_key *) CONST_CAST(struct miniflow *, mf);
> + struct netdev_flow_key *key;
> +
> + INIT_CONTAINER(key, miniflow, mf);
> +
> + return key;
> }
>
>
>
> Seems this function is no longer used,
>
Oops.
>
> +/* Insert 'rule' into 'cls'. */
> +static void
> +dpcls_insert(struct dpcls *cls, struct dpcls_rule *rule,
> + const struct netdev_flow_key *mask)
> +{
> + struct dpcls_subtable *subtable = dpcls_find_subtable(cls, mask);
> +
> + rule->mask = &subtable->mask;
> + cmap_insert(&subtable->rules, &rule->cmap_node, rule->flow.hash);
> +}
> +
>
> Could we add thread-safety tags to these dpctl_*()?
>
OK
Jarno
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
