> > > > > Signed-off-by: Niels van Adrichem <n.l.m.vanadric...@tudelft.nl> > > Thanks. I applied this. It is definitely an improvement. > > There are two ways that we should continue to improve it, though. One > is incremental: CFM, as well as BFD, should control forwarding.
Hey Ben, could you explain more on this 'incremental'? I think with this commit, the bfd does control the forwarding of group action in the following way: 1. when bfd forwarding flag flaps, it changes the global sequence number. 2. as reaction to global sequence number change, port_run() is executed. 3. if the port_run() execution finds that the 'ofport->may_enable' flaps and sets the 'backer->need_revalidate'. 4. the set of 'backer->need_revalidate' causes the dp flow revalidation and changes the forwarding of group action. Does this make sense? Thanks, Alex Wang, > The > other is that the "live" bit in the OpenFlow port status is supposed to > track whether a port is live for this purpose; I don't think OVS is > doing the right thing there. > _______________________________________________ > dev mailing list > dev@openvswitch.org > http://openvswitch.org/mailman/listinfo/dev > _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev