On Wed, Oct 15, 2014 at 01:54:52PM +0000, Niels van Adrichem wrote: > Integration of each interface' status as confirmed by BFD into the > FastFailover Group table. When BFD is configured and function > bfd_forwarding() reports false, odp_port_is_alive also reports false in > order to have a watched interface report false and omit to another > backup. > > Test-suite has been succesfully run, as well as testing with ICMP echo > requests and replies that traffic was succesfully rerouted over the > backup path. More extensive load-consumption tests with a function that > only checked whether (bfd->state == STATE_UP) have been succesfully > performed, but was later changed to use the larger function > bfd_forwarding() as it captures all possible exceptions and is properly > mutually excluded. > > Signed-off-by: Niels van Adrichem <n.l.m.vanadric...@tudelft.nl>
Thanks. I applied this. It is definitely an improvement. There are two ways that we should continue to improve it, though. One is incremental: CFM, as well as BFD, should control forwarding. The other is that the "live" bit in the OpenFlow port status is supposed to track whether a port is live for this purpose; I don't think OVS is doing the right thing there. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
