Thanks for the review! Pushed to master, working on the back port now.
Jarno On Oct 6, 2014, at 1:27 PM, Ben Pfaff <b...@nicira.com> wrote: > On Wed, Oct 01, 2014 at 04:02:32PM -0700, Jarno Rajahalme wrote: >> Previously we masked labels not present in the incoming packet. >> >> Signed-off-by: Jarno Rajahalme <jrajaha...@nicira.com> > > Nice improvement. > > Here, I think I meant to write "second or later", which also makes > sense if we increase FLOW_MAX_MPLS_LABELS: >> - * If the new label is the second or label MPLS label in 'flow', it is >> + * If the new label is the second or third label MPLS label in 'flow', it is > > The change to mf_is_all_wild() looks to me like a bug fix that should > be backported. > > I'd drop the 'wc' parameter from commit_mpls_action() instead of > marking it unused. > > Acked-by: Ben Pfaff <b...@nicira.com> _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
