________________________________________
From: Samuel Ghinet
Sent: Tuesday, September 30, 2014 6:24 PM
To: Nithin Raju
Subject: RE: [PATCH] datapath-windows: NUL character should be left out during
VPORT hash lookup
The vport names given by the userspace using netlink command vport add are
null-terminated.
I personally see this patch as an unnecessary complexity.
Regards,
Sam
________________________________________
From: Nithin Raju [nit...@vmware.com]
Sent: Friday, September 26, 2014 4:05 AM
To: dev@openvswitch.org; Samuel Ghinet
Cc: Nithin Raju
Subject: [PATCH] datapath-windows: NUL character should be left out during
VPORT hash lookup
While calculating the hash on a VPORT name, we don't include the NUL character.
We should be doing the same while doing lookup as well.
Signed-off-by: Nithin Raju <nit...@vmware.com>
---
datapath-windows/ovsext/Datapath.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/datapath-windows/ovsext/Datapath.c
b/datapath-windows/ovsext/Datapath.c
index 495219e..65b4b81 100644
--- a/datapath-windows/ovsext/Datapath.c
+++ b/datapath-windows/ovsext/Datapath.c
@@ -1468,7 +1468,7 @@ OvsGetVport(POVS_USER_PARAMS_CONTEXT usrParamsCtx,
if (vportAttrs[OVS_VPORT_ATTR_NAME] != NULL) {
vport = OvsFindVportByOvsName(gOvsSwitchContext,
NlAttrGet(vportAttrs[OVS_VPORT_ATTR_NAME]),
- NlAttrGetSize(vportAttrs[OVS_VPORT_ATTR_NAME]));
+ NlAttrGetSize(vportAttrs[OVS_VPORT_ATTR_NAME]) - 1);
} else if (vportAttrs[OVS_VPORT_ATTR_PORT_NO] != NULL) {
vport = OvsFindVportByPortNo(gOvsSwitchContext,
NlAttrGetU32(vportAttrs[OVS_VPORT_ATTR_PORT_NO]));
--
1.7.4.1
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
