It would save a lot of time for both of us if you would just post your patches.
On Mon, Sep 22, 2014 at 08:09:03PM +0530, Rishi Bamba wrote: > Hi Ben, > > In reference to the mail dated 15.09.2014 I would like to thank you for your > continued support to the team.Attached is the mail for reference. > > In progress to the same ,so far we have achieved the below mentioned.Wanted > to share the understanding and confirmation on the same. > > > Case 1: Flow Added with default active version on OpenvSwitch ( OF10 ) > alongwith importance > ( Eviction implementation in accordance with OF1.4 ). > > Add Flow Command(OF10) : ovs-ofctl add-flow br0 > priority=21,importance=21,action=normal > Output: No Error , rule saved but with default importance( i.e zero ) rather > than with the specified value by user. > > > Dump-Flow Command(OF 10) : ovs-ofctl dump-flows br0 > Output: cookie=0x0, duration=8.736s, table=0, n_packets=0, n_bytes=0, > idle_age=8, priority=21 actions=NORMAL > > Dump-Flow Command(OF 11+) : ovs-ofctl -O OpenFlow13 dump-flows br0 > Output: cookie=0x0, duration=116.980s, table=0, n_packets=6, n_bytes=546, > priority=21 actions=NORMAL > > The understanding is ,if the flow is added by the default active version i.e > OF10 , the added flow will have importance set as zero whether provided by > the user or not.The same is reflected in the dump flows either via OF10 or > OF11+ . If importance is zero it will not be visible in that case. > > Query 1: Is this handling correct or we need to throw a message to the user > that "importance" is supported by a particular version only rather than > making it zero. Also as we are using OF11 flow mod structure as mentioned in > previous mail, will importance parameter in add-flow should be supported on > 1.1+ or we have to make it OF1.4 specific only. > > > > Case 2: Flow Added with specific version on OpenvSwitch ( OF11+ ) alongwith > importance > (Eviction implementation in accordance with OF1.4 ). > > Add Flow Command(OF11+) : ovs-ofctl -O OpenFlow13 add-flow br0 > priority=22,importance=22,action=drop > Output: No Error , rule saved with the value provided by the user and else > zero if not provided by the user. > > > Dump-Flow Command(OF 10) : ovs-ofctl dump-flows br0 > Output: (IMPORTANCE NOT VISIBLE) > cookie=0x0, duration=47.841s, table=0, n_packets=2, n_bytes=182, idle_age=24, > priority=22 actions=drop > cookie=0x0, duration=243.481s, table=0, n_packets=6, n_bytes=546, > idle_age=152, priority=21 actions=NORMAL > > Dump-Flow Command(OF 11+) : ovs-ofctl -O OpenFlow13 dump-flows br0 > Output: (IMPORTANCE VISIBLE FOR THE FLOWS HAVING VALUE SET FOR THE FIELD) > cookie=0x0, duration=141.275s, table=0, n_packets=2, n_bytes=182, > importance=22, priority=22 actions=drop > cookie=0x0, duration=336.915s, table=0, n_packets=6, n_bytes=546, priority=21 > actions=NORMAL > > The understanding is,if the flow is added by a specific version (OF11+), the > added flow will have importance set as the value provided by the user else > zero.Now if the user dump-flows with the default version (OF10) none of the > flows importance parameter will be visible even for the set one's else if > dump-flows via OF11+ , the importance parameter will be visible for the flows > which have the parameter set of. > > Query 2: Do we need to show the importance field if a flow is added by OF11+ > and dump-flows via OF10. Currently we are not showing as mentioned above.Also > this should also be only 1.4 specific or 1.1+ is fine. > > > Note: On finalizing the the above mentioned approach we will be submitting > the patch for the same at the earliest. Need your confirmation on the above > working. > > > Thank You > Regards > Rishi Bamba > 0-9899863386 > > =====-----=====-----===== > Notice: The information contained in this e-mail > message and/or attachments to it may contain > confidential or privileged information. If you are > not the intended recipient, any dissemination, use, > review, distribution, printing or copying of the > information contained in this e-mail message > and/or attachments to it are strictly prohibited. If > you have received this communication in error, > please notify us by reply e-mail or telephone and > immediately and permanently delete the message > and any attachments. Thank you > > > Date: Sun, 14 Sep 2014 13:50:23 -0700 > From: Ben Pfaff <b...@nicira.com> > To: Rishi Bamba <rishi.ba...@tcs.com> > Cc: dev@openvswitch.org > Subject: Re: [ovs-dev] Addition of importance parameter in flow_mod > structure for implementation of eviction according to OF1.4 > User-Agent: Mutt/1.5.21 (2010-09-15) > > On Fri, Sep 12, 2014 at 05:55:18PM +0530, Rishi Bamba wrote: > > 1. Currently we have modified ofp11_flow_mod in openflow-1.1.h for > > addition of "ovs_be16 importance" parameter. > > > > Query: Do we need to create ofp14_flow_mod as the structure is > > currently not present in openflow-1.4.h or the enhancement to > > ofp11_flow_mod in openflow-1.1.h is justified. > > It's OK to update ofp11_flow_mod because the new member just assigns a > meaning to a field previously used for padding. > > > 2. We noticed that when using "add-flow" command with argument "-O > > OpenFlow14" a error message is thrown > > You should enable OF1.4. See the FAQ. > > Q: What versions of OpenFlow does Open vSwitch support? > > A: The following table lists the versions of OpenFlow supported by > each version of Open vSwitch: > > Open vSwitch OF1.0 OF1.1 OF1.2 OF1.3 OF1.4 OF1.5 > =============== ===== ===== ===== ===== ===== ===== > 1.9 and earlier yes --- --- --- --- --- > 1.10 yes --- [*] [*] --- --- > 1.11 yes --- [*] [*] --- --- > 2.0 yes [*] [*] [*] --- --- > 2.1 yes [*] [*] [*] --- --- > 2.2 yes [*] [*] [*] [%] [*] > 2.3 yes yes yes yes [*] [*] > > [*] Supported, with one or more missing features. > [%] Experimental, unsafe implementation. > > Open vSwitch 2.3 enables OpenFlow 1.0, 1.1, 1.2, and 1.3 by default > in ovs-vswitchd. In Open vSwitch 1.10 through 2.2, OpenFlow 1.1, > 1.2, and 1.3 must be enabled manually in ovs-vswitchd. OpenFlow > 1.4 and 1.5 are also supported, with missing features, in Open > vSwitch 2.3 and later, but not enabled by default. In any case, > the user may override the default: > > - To enable OpenFlow 1.0, 1.1, 1.2, and 1.3 on bridge br0: > > ovs-vsctl set bridge br0 > protocols=OpenFlow10,OpenFlow11,OpenFlow12,OpenFlow13 > > - To enable OpenFlow 1.0, 1.1, 1.2, 1.3, 1.4, and 1.5 on bridge br0: > > ovs-vsctl set bridge br0 > protocols=OpenFlow10,OpenFlow11,OpenFlow12,OpenFlow13,OpenFlow14,OpenFlow15 > > - To enable only OpenFlow 1.0 on bridge br0: > > ovs-vsctl set bridge br0 protocols=OpenFlow10 > > All current versions of ovs-ofctl enable only OpenFlow 1.0 by > default. Use the -O option to enable support for later versions of > OpenFlow in ovs-ofctl. For example: > > ovs-ofctl -O OpenFlow13 dump-flows br0 > > (Open vSwitch 2.2 had an experimental implementation of OpenFlow > 1.4 that could cause crashes. We don't recommend enabling it.) > > OPENFLOW-1.1+ in the Open vSwitch source tree tracks support for > OpenFlow 1.1 and later features. When support for OpenFlow 1.4 and > 1.5 is solidly implemented, Open vSwitch will enable those version > by default. Also, the OpenFlow 1.5 specification is still under > development and thus subject to change. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
