In our experience, most people actually expect this number to be fairly high. For example, our traffic generator runs a little bit of traffic to populate caches, pauses for a couple of seconds, before finally starting the main test. On top of that, we've had some minor complaints from people managing deployments about how low this number is.
Originally we used 1.5 seconds because the flow revalidation was so slow that we wanted to seriously limit the size of the flow table to be sure we can keep up. However, now that we've made such scale improvements, bumping the default up seems reasonable. All of that said, we don't feel all that strongly about this change, is there a specific concern you have? Perhaps we can address it... Ethan On Thu, Sep 18, 2014 at 5:56 AM, Flavio Leitner <f...@redhat.com> wrote: > On Fri, Sep 12, 2014 at 10:03:56AM +1200, Joe Stringer wrote: >> The datapath max_idle value determines how long to wait before deleting >> an idle datapath flow when operating below the flow_limit. This patch >> increases the max_idle to 10 seconds, which allows datapath flows to be >> remain cached even if they are used less consistently, and provides a >> small improvement in the supported number of flows when operating around >> the flow_limit. > > Could you tell what would be the motivation behind this change? > > fbl > >> Signed-off-by: Joe Stringer <joestrin...@nicira.com> >> --- >> ofproto/ofproto.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/ofproto/ofproto.h b/ofproto/ofproto.h >> index 1b8709a..d60b198 100644 >> --- a/ofproto/ofproto.h >> +++ b/ofproto/ofproto.h >> @@ -267,7 +267,7 @@ int ofproto_port_dump_done(struct ofproto_port_dump *); >> ) >> >> #define OFPROTO_FLOW_LIMIT_DEFAULT 200000 >> -#define OFPROTO_MAX_IDLE_DEFAULT 1500 >> +#define OFPROTO_MAX_IDLE_DEFAULT 10000 /* ms */ >> >> const char *ofproto_port_open_type(const char *datapath_type, >> const char *port_type); >> -- >> 1.7.10.4 >> >> _______________________________________________ >> dev mailing list >> dev@openvswitch.org >> http://openvswitch.org/mailman/listinfo/dev >> > _______________________________________________ > dev mailing list > dev@openvswitch.org > http://openvswitch.org/mailman/listinfo/dev _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
