On Mon, Aug 18, 2014 at 07:48:10AM -0700, Gurucharan Shetty wrote: > Commit d73105839 (netdev-dpdk: Move to DPDK 1.7.0) added > 'vswitchd_ovs_vswitchd_LDFLAGS' in acinclude.m4. This caused the > created Makefile to use 'vswitchd_ovs_vswitchd_LINK' without > including 'AM_LDFLAGS'. This causes failure while building ovs-vswitchd > with external libraries (ex: ovs-vswitchd on Windows with openssl.) > > This commit adds 'AM_LDFLAGS' to the new 'vswitchd_ovs_vswitchd_LDFLAGS'. > > Signed-off-by: Gurucharan Shetty <gshe...@nicira.com>
I didn't review commit d73105839 until now. I don't think it's wise to substitute an Automake-owned variable that way. It's not commonly done, so it might confuse readers (it would confuse me), and I doubt that Automake guarantees that it will continue to work. I would rather see acinclude.m4 substitute some variable whose name is not owned by Automake, e.g. DPDK_LDFLAGS, and then in automake.mk write vswitchd_ovs_vswitchd_LDFLAGS = $(AM_LDFLAGS) $(DPDK_LDFLAGS). Does that make sense? Thanks, Ben. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
