Hello, Thanks for the feedback! I'll try to stick better to the issues on github :)
Justin, regarding referencing isuses in github, like "ovs/ovs-issues#42", thanks for the idea! I understand that this must be put in the text associated with the patch, and this would allow linking once it's accepted in the ovs repo. Saurabh, "Unless there is an immediate patch that is using that functionality, it shouldn’t be posted for review" Okay, got it :) I was also influenced in falling short of this by the fact that the current ovs-win driver has quite lots of symbols & functions that it does not use at all. But since these were from the "initial push" on the repo, I understand it is a different case altogether :) Thanks! Sam ________________________________________ From: Ben Pfaff [b...@nicira.com] Sent: Thursday, August 07, 2014 12:16 AM To: Nithin Raju Cc: Saurabh Shah; dev@openvswitch.org; Samuel Ghinet Subject: Re: [ovs-dev] Recent series of patches Yes, it would be helpful to use that form. So far I've transformed the issue references in the patches I've committed into that form. If some other form is better for github then let's write up the appropriate format as a patch to CONTRIBUTING. Thanks, Ben. On Wed, Aug 06, 2014 at 09:14:23PM +0000, Nithin Raju wrote: > BTW, CONTRIBUTING file mentions a "Reported-at: " that we could use > to provide specific links to the issue addressed. > > -- Nithin > > On Aug 6, 2014, at 2:01 PM, Saurabh Shah <ssaur...@vmware.com> > wrote: > > >> Since our issue tracker is in a different repo from the code, I think you > >> need > >> to reference issues in the following way: > >> > >> ovs/ovs-issues#42 > >> > > > > This is good to know. I wasn't aware about this. Thanks Justin! > > > > -- Saurabh > > _______________________________________________ > dev mailing list > dev@openvswitch.org > http://openvswitch.org/mailman/listinfo/dev _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
