On Wed, Jun 25, 2014 at 2:59 AM, Thomas Graf <tg...@noironetworks.com>
wrote:

> On 06/24/14 at 06:40pm, Alex Wang wrote:
> > Signed-off-by: Alex Wang <al...@nicira.com>
> > ---
> > PATCH -> V2:
> > - Rebase.
>
> LGTM, minor nitpick below.
>
> Acked-by: Thomas Graf <tg...@noironetworks.com>
>
> > diff --git a/lib/netdev-dpdk.h b/lib/netdev-dpdk.h
> > index f443a21..da507ce 100644
> > --- a/lib/netdev-dpdk.h
> > +++ b/lib/netdev-dpdk.h
> > @@ -20,13 +20,18 @@ struct dpif_packet;
> >  #include <rte_launch.h>
> >  #include <rte_malloc.h>
> >
> > +struct netdev;
>
> Just in case you are going to rebase again anyway: Moving this
> up to the struct dpif_packet declaration would avoid the need to
> declare it again for non-dpdk.
>


Thx, will do,
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to