On 06/24/14 at 06:40pm, Alex Wang wrote: > Signed-off-by: Alex Wang <al...@nicira.com> > > --- > PATCH -> V2: > - Use readdir_r() instead of readdir() for reentrency. > - Address review comments from Thomas Graf. > - Add dummy interface for WIN32 case.
One minor comment below. > index 85ecc5c..77b9b39 100644 > --- a/tests/ofproto-macros.at > +++ b/tests/ofproto-macros.at > @@ -76,6 +76,7 @@ m4_define([OVS_VSWITCHD_START], > AT_CHECK([ovs-vswitchd --detach --no-chdir --pidfile --enable-dummy$3 > --disable-system --log-file -vvconn -vofproto_dpif], [0], [], [stderr]) > AT_CAPTURE_FILE([ovs-vswitchd.log]) > AT_CHECK([[sed < stderr ' > +/ovs_numa|INFO|Discovered /d > /vlog|INFO|opened log file/d > /vswitchd|INFO|ovs-vswitchd (Open vSwitch)/d > /reconnect|INFO|/d I would expect that the above extended test fails for the Win32 port as the NUMA discovery is not done. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
