On Wed, Jun 11, 2014 at 11:31:37AM -0700, Ben Pfaff wrote: > On Sat, May 31, 2014 at 01:53:16AM -0300, Flavio Leitner wrote: > > Add IGMP support to struct flow, flow compose and flow extract. > > > > Signed-off-by: Flavio Leitner <f...@redhat.com> > > If the ofproto code is going to match on particular IGMP type or code > or group internally, then we need to also modify odp-util.c > parse_l2_5_onward() to return ODP_FIT_TOO_LITTLE when parsing IGMP. > But I think that so far we're planning to always slow-path IGMP, so I > don't think that's necessary yet. It would be easy to forget it > later, so maybe we should do it now? Not sure.
Ben, I think that change goes out of the scope of this patchset since it's targeted for IGMP snooping only. However, I agree that the patch's title is misleading and I could change it to something like: "flow: extend it to carry IGMP protocol information" fbl _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
