On Fri, May 30, 2014 at 12:06:16PM -0700, Gurucharan Shetty wrote: > When a OVS daemon is configured to run as a Windows service, > when the service is stopped by calling service_stop(), the > windows services manager does not give enough time to do > everything in the atexit handler. So call the exit handler > directly from service_stop(). > > Signed-off-by: Gurucharan Shetty <gshe...@nicira.com
As a global function, the name atexit_handler() sounds like something in the C library. I would add a "fatal_signal_" prefix. This change seems unrelated to the topic of the patch, and a little risky (since it doesn't set pidfile to NULL, calling it twice would double-free): > @@ -404,6 +409,7 @@ unlink_pidfile(void) > } > if (pidfile) { > unlink(pidfile); > + free(pidfile); > } > } _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev