I had a look, and just separating out the vhost functions would require exposing many of the static structures and functions in the header file which isn't ideal, so I'm going to combine them into one, as I didn't see any other ports that exposed their static structures in the header files...
Regards Maryam -----Original Message----- From: Pravin Shelar [mailto:pshe...@nicira.com] Sent: Wednesday, June 4, 2014 10:00 PM To: Tahhan, Maryam Cc: dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH 1/1] netdev-dpdk-vhost / add dpdk vhost ports On Wed, Jun 4, 2014 at 2:48 AM, Tahhan, Maryam <maryam.tah...@intel.com> wrote: > Hi Pravin > Are you suggesting adding the dpdk-vhost interface code into netdev-dpdk.c, > defining a common netdev_class and working from there (similar to > netdev-linux and tap devices etc.)? > It does break up modularity somewhat in that vhost ports are logical and > distinct from dpdk ports, but it can be done. Or would abstracting out what > is common into a set of functions that dpdk ports (logical/physical) can use > be more suitable? > I agree vhost are logically different but since both are poll mode device they do share device some functionality. So you can keep vhost in separate file and share functions and structures from netdev-dpdk. Thanks, Pravin. -------------------------------------------------------------- Intel Shannon Limited Registered in Ireland Registered Office: Collinstown Industrial Park, Leixlip, County Kildare Registered Number: 308263 Business address: Dromore House, East Park, Shannon, Co. Clare This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
