Hi Pravin Are you suggesting adding the dpdk-vhost interface code into netdev-dpdk.c, defining a common netdev_class and working from there (similar to netdev-linux and tap devices etc.)? It does break up modularity somewhat in that vhost ports are logical and distinct from dpdk ports, but it can be done. Or would abstracting out what is common into a set of functions that dpdk ports (logical/physical) can use be more suitable?
--Maryam -----Original Message----- From: Pravin Shelar [mailto:pshe...@nicira.com] Sent: Tuesday, June 3, 2014 8:03 PM To: Tahhan, Maryam Cc: dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH 1/1] netdev-dpdk-vhost / add dpdk vhost ports On Tue, Jun 3, 2014 at 3:20 AM, maryam.tahhan <maryam.tah...@intel.com> wrote: > This patch implements the vhost-net offload API. It adds support for > a new port type to userspace datapath called dpdkvhost. This allows > KVM > (QEMU) to offload the servicing of virtio-net devices to it's > associated dpdkvhost port. Instructions for use are in INSTALL.DPDK. > > This has been tested on Intel multi-core platforms and with clients > that have virtio-net interfaces. > Thanks for the patch. I have not done with reviewing this patch, but have a high level comment. I see some common code in netdev-dpdk and netdev-dpdk-vhost, Is it possible to reuse that code? something like Gerald did for dpdk rings patch. > Signed-off-by: maryam.tahhan <maryam.tah...@intel.com> > --- > INSTALL.DPDK | 190 +++++ > Makefile.am | 44 +- > configure.ac | 1 + > lib/automake.mk | 9 +- > lib/netdev-bsd.c | 1 - > lib/netdev-dpdk-vhost.c | 1219 > +++++++++++++++++++++++++++++++++ > lib/netdev-dpdk-vhost.h | 62 ++ > lib/netdev-dpdk.c | 62 +- > lib/netdev-dpdk.h | 13 + > lib/netdev.c | 5 +- > lib/vhost-net-cdev.c | 374 ++++++++++ > lib/vhost-net-cdev.h | 81 +++ > lib/virtio-net.c | 989 ++++++++++++++++++++++++++ > lib/virtio-net.h | 117 ++++ > utilities/automake.mk | 3 +- > utilities/eventfd_link/Makefile.in | 86 +++ > utilities/eventfd_link/eventfd_link.c | 189 +++++ > utilities/eventfd_link/eventfd_link.h | 79 +++ > utilities/qemu-wrap.py | 389 +++++++++++ > 19 files changed, 3858 insertions(+), 55 deletions(-) create mode > 100644 lib/netdev-dpdk-vhost.c create mode 100644 > lib/netdev-dpdk-vhost.h create mode 100644 lib/vhost-net-cdev.c > create mode 100644 lib/vhost-net-cdev.h create mode 100644 > lib/virtio-net.c create mode 100644 lib/virtio-net.h create mode > 100644 utilities/eventfd_link/Makefile.in > create mode 100644 utilities/eventfd_link/eventfd_link.c > create mode 100644 utilities/eventfd_link/eventfd_link.h > create mode 100755 utilities/qemu-wrap.py > .... -------------------------------------------------------------- Intel Shannon Limited Registered in Ireland Registered Office: Collinstown Industrial Park, Leixlip, County Kildare Registered Number: 308263 Business address: Dromore House, East Park, Shannon, Co. Clare This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
