You are right, sorry for misreading your patch. Acked-by: Alex Wang <al...@nicira.com>
On Tue, Jun 3, 2014 at 2:51 PM, Joe Stringer <joestrin...@nicira.com> wrote: > On 4 June 2014 05:39, Alex Wang <al...@nicira.com> wrote: > >> I confirm this patch fix the bug, but have a high level concern, >> >> >> Assume another learnt flow with hard_timeout=10 and was never hit after >> install, now, if there is frequent change to the flow table and >> need_revalidate >> is constantly 'true', this learnt flow will never timeout... since we >> always >> redo the flow_mod during revalidation, >> > > (Correct me if I'm wrong, but this is how I see it:) > For this particular case, we will not redo the flow_mod during > revalidation. The "may_learn" flag is the same as before. Now, we will > create the flow_mod and cache it, but only do the flow_mod if may_learn is > true. > > The "execute_learn" function is perhaps a bit misleading here: It only > assembles the flow_mod, doesn't actually execute it. >
_______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
