On Tue, May 20, 2014 at 03:21:09PM -0700, Ben Pfaff wrote:
> On Fri, Apr 11, 2014 at 06:34:12PM -0300, Flavio Leitner wrote:
> > Add a switch to enable or disable multicast snooping on
> > the bridge. This feature is disabled by default.
> >
> > Acked-by: Thomas Graf <[email protected]>
> > Acked-by: Daniel Borkmann <[email protected]>
> > Signed-off-by: Flavio Leitner <[email protected]>
>
> Is it at all likely that we'll want to enable this by default someday?
Well, it's a feature that saves some resources like bandwidth
and CPU, so I think it should be enabled by default.
> If so, then the documentation might want to be more vague about
> whether it's disabled by default ("For now, ....").
Ok, will fix that too.
> I guess that we will initially snoop only IGMPv4. That should
> probably be documented. If we add IGMPv6 later, will it need to be
> enabled separately?
I don't think so. Either you enable multicast snooping for all
supported protocols or disable it for all.
> We normally add documentation for a feature in the same commit that
> adds the feature, so this commit should probably be squashed with
> whichever commit actually adds support.
Sure, I can fix that.
Thanks!
fbl
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
