On Fri, May 09, 2014 at 08:39:32AM -0700, Ben Pfaff wrote: > On Thu, Apr 10, 2014 at 12:50:10PM +0200, Thomas Graf wrote: > > Store the error condition of a failed port configuration in a new > > column 'error' in the Interface table. > > > > Example: > > $ ovs-vsctl add-port br0 test -- \ > > set Interface test type=vxlan options:unknown=1 > > ovs-vsctl: Error detected while setting up 'test'. [...] > > > > $ ovs-vsctl list Interface test | grep error > > error : "test: could not set configuration (Invalid argument)" > > > > Fixing the error will clear the error column: > > $ ovs-vsctl set Interface test options:remote_ip=1.1.1.1 > > $ ovs-vsctl list Interface test | grep error > > error : [] > > $ > > > > For now, the high level error messages when opening and configuring > > the netdev are used. Further patches can extend passing the error > > pointer into the individual netdev implementations to allow for more > > fine grained error messages to be stored. > > > > Signed-off-by: Thomas Graf <tg...@redhat.com> > > I would like to clarify the description in the documentation, to make it > clear, first, that Open vSwitch fills this column, not the user > (sometimes users have trouble figuring that out), and second that the > actual failure is indicated by the ofport column. How about this: > > <column name="error"> > If the configuration of the port failed, as indicated by -1 in > <ref column="ofport"/>, Open vSwitch sets this column to an > error description in human readable form. Otherwise, Open > vSwitch clears this column. > </column>
I'm otherwise happy with the series. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
