On Apr 18, 2014, at 2:26 AM, YAMAMOTO Takashi <[email protected]> wrote:
>> Use miniflow as a flow key in the userspace datapath classifier. The >> miniflow is expanded for upcalls, but for existing datapath flows, the >> key need not be expanded. >> >> Signed-off-by: Jarno Rajahalme <[email protected]> > > Reviewed-by: YAMAMOTO Takashi <[email protected]> > Pushed to master, Jarno >> @@ -2144,8 +2157,9 @@ dp_execute_cb(void *aux_, struct ofpbuf *packet, >> >> hash_act = nl_attr_get(a); >> if (hash_act->hash_alg == OVS_HASH_ALG_L4) { >> - >> - hash = flow_hash_symmetric_l4(aux->key, hash_act->hash_bias); >> + /* Hash need not be symmetric, nor does it need to include >> + * L2 fields. */ >> + hash = miniflow_hash_5tuple(aux->key, hash_act->hash_bias); > > how do you think about ipv6? I noticed support for it was missing in the existing flow_hash_5tuple, and agree that both that and the new miniflow_hash_5tuple() need to be improved to add support for IPv6. I’ll send a new patch doing that. > > YAMAMOTO Takashi _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
