On Apr 18, 2014, at 2:28 AM, YAMAMOTO Takashi <yamam...@valinux.co.jp> wrote:
>> Add inlined generic accessors for miniflow integer type fields, and a >> new miniflow_get_tcp_flags() usinge these. These will be used in a >> later patch. >> >> Some definitions also used in lib/packets.h had to be moved there to >> resolve circular include dependencies. Similarly, some inline >> functions using struct flow are now in lib/flow.h. IMO this is >> cleaner, since now the lib/flow.h need not be included from >> lib/packets.h. >> >> Signed-off-by: Jarno Rajahalme <jrajaha...@nicira.com> > > at least tests/test-sflow.c needs arpa/inet.h for inet_ntop > as it isn't indirectly included via packets.h anymore. > Added, thanks! > otherwise looks fine to me. > > Reviewed-by: YAMAMOTO Takashi <yamam...@valinux.co.jp> Pushed to master, Jarno _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
