On Tue, Jan 21, 2014 at 11:29:23AM -0800, Joe Stringer wrote: > Currently, we have a single thread (the 'flow_dumper') that fetches the flows > from the datapath and distributes them to revalidator threads. To clean up the > code (and provide a small performance benefit), we are looking at removing > this > flow_dumper thread, and have each revalidator fetch flows from the datapath > instead.
I applied a couple of these patches that make sense to me whether we use multithreaded dumping or not. But it sounds like the intended user for these patches (to eliminate the revalidation flow dumper thread) hasn't shown a performance improvement yet, so until we do that I'd prefer to defer final review on the others, because these patches do make the code a little harder to understand. Thanks, Ben. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
