On 13 January 2014 15:28, Ben Pfaff <[email protected]> wrote: > On Fri, Jan 10, 2014 at 11:43:15AM -0800, Joe Stringer wrote: > > This new function allows callers to determine whether the contents of > > the given buffer will be modified or reallocated on the next call to > > dpif_flow_dump_next(). This will be used in a future commit to allow > > batched flow deletion by revalidator threads. > > > > Signed-off-by: Joe Stringer <[email protected]> > > --- > > I was a little unsure on the longevity of an interface like this; I > could pass > > the dpif and/or state and/or other pointers down to the dpif > implementation, > > but these appear to be all unnecessary for dpif-linux. Furthermore, if > another > > implementation wishes to provide this function, they can always put any > > relevant information at the start of their buffer for re-use. Willing to > > change it though. > > I'd rather put this kind of commit at the start of a series that is > going to start using it, rather than at the end of a series that > doesn't, because it's easier to judge whether it's worthwhile and to > think about alternatives in taht case. >
Sure, that makes sense. I'll omit this patch from reposts of the series, and pass it on to Ethan to place at the beginning of his series that uses it.
_______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
