On Fri, Jan 10, 2014 at 11:43:08AM -0800, Joe Stringer wrote: > The 'buffer' member in 'struct nl_dump' will be going away, so this > patch ensures that nl_dump_done() no longer uses it to drain the > nl_sock. > > Signed-off-by: Joe Stringer <[email protected]>
As written, every call to nl_dump_done() will allocate and free a 4 kb buffer, when most of the time that is wasted effort. I suggest allocating a NL_DUMP_BUFSIZE (or 4 kb or whatever) local buffer and using ofpbuf_use_stub() to avoid the allocation. Thanks, Ben. _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
