On Dec 17, 2013, at 10:10 AM, Ben Pfaff <b...@nicira.com> wrote: > On Tue, Dec 17, 2013 at 12:16:23AM -0800, Alex Wang wrote: >> Commit da546e0 (dpif: Allow execute to modify the packet.) uninitializes >> the "dpif_upcall.packet" of "struct upcall" when dpif_recv() returns error. >> Since the "struct upcall" is allocated via xmalloc, this will cause SEGFAULT >> if dpif_recv() returns error before memset the memory to all zero. >> >> This commit fixes the bug by using xzalloc to allocate memory for "struct >> upcall". >> >> Signed-off-by: Alex Wang <al...@nicira.com> > > A struct upcall is quite large. I would prefer not to clear the whole > thing if we can avoid it.
I just sent a patch that avoids it. Jarno _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
