sure,

> So the problem is that in error cases the ofpbuf packet member of upcall
> has been uninitialized. The fix you propose works because all-zero ofpbuf
> can be safely uninitialized.


Yes, my fix is more like a hack that relies on this.


> We have not documented this behavior anywhere, so I’m not sure if we
> should rely on it. The alternative would be to properly initialize the
> packet member also for error returns (and document whose responsibility it
> is.). I’ll send a patch soon to this effect for you to review.
>

I'd like to review it, thx
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to