On Fri, Nov 22, 2013 at 10:41:18AM -0800, Joe Stringer wrote:
> On 20 November 2013 11:15, Ben Pfaff <b...@nicira.com> wrote:
> >> NB: I'm tracking STP changes in ofproto_port_set_state(), as the testsuite
> >> would fail when I tracked them in stp_set_port_state(). The latter makes 
> >> more
> >> sense to me, but I clearly don't understand some interaction there because 
> >> it
> >> makes STP stop working. I tried a few combinations in lib/stp.c, but I 
> >> couldn't
> >> get any of them to work.
> >
> > Hmm.  I agree that's odd.
> 
> I tracked it down; It was a segfault in test-stp. I didn't realise
> that the STP test used the same library. When stp-test updated the
> global seq from inside the STP code, it was trying to access the (as
> yet unitialized) global seq. I am thinking of making
> connectivity_seq_init() construct once per process (is there a way to
> conveniently do this?). Then we can initialize it in stp_init().

You can use pthread_once() or "struct ovsthread_once" for once-only
initialization.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to