On Wed, Nov 13, 2013 at 10:48 AM, Andy Zhou <az...@nicira.com> wrote: > The comment change is fine. > > Not related to the comment, I am not happy with the abstraction of > flow_mask_insert() -- passing in flow, and setting up flow->mask should not > be part of the insert() function. > > A better function name may help. I did not come up with a better one. > > On the other hand, how about removing this function -- there is only one > caller -- embedding the logic within the original function may actually be > more readable.
Hmm, I guess it seems about the same either way to me. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
