The comment change is fine.
Not related to the comment, I am not happy with the abstraction of
flow_mask_insert() -- passing in flow, and setting up flow->mask should not
be part of the insert() function.
A better function name may help. I did not come up with a better one.
On the other hand, how about removing this function -- there is only one
caller -- embedding the logic within the original function may actually be
more readable.
On Wed, Nov 13, 2013 at 9:54 AM, Ben Pfaff <b...@nicira.com> wrote:
> Signed-off-by: Ben Pfaff <b...@nicira.com>
> ---
> datapath/flow_table.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/datapath/flow_table.c b/datapath/flow_table.c
> index ddb14da..4804db0 100644
> --- a/datapath/flow_table.c
> +++ b/datapath/flow_table.c
> @@ -519,11 +519,7 @@ static struct sw_flow_mask *flow_mask_find(const
> struct flow_table *tbl,
> return NULL;
> }
>
> -/**
> - * add a new mask into the mask list.
> - * The caller needs to make sure that 'mask' is not the same
> - * as any masks that are already on the list.
> - */
> +/* Add 'mask' into the mask list, if it is not already there. */
> static int flow_mask_insert(struct flow_table *tbl, struct sw_flow *flow,
> struct sw_flow_mask *new)
> {
> --
> 1.7.10.4
>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
>
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
