On Tue, Nov 05, 2013 at 10:43:20AM -0800, Romain Lenglet wrote:
> Signed-off-by: Romain Lenglet <[email protected]>
I had to stare at bridge_configure_ipfix() for a while before I could
see the bug. I think that this bug arises because this code:
sset_add_array(&opts->targets, fe_cfg->ipfix->targets,
fe_cfg->ipfix->n_targets);
opts->cache_active_timeout = fe_cfg->ipfix->cache_active_timeout
? *fe_cfg->ipfix->cache_active_timeout : 0;
opts->cache_max_flows = fe_cfg->ipfix->cache_max_flows
? *fe_cfg->ipfix->cache_max_flows : 0;
wasn't bracketed by a test for nonnull fe_cfg->ipfix. Is that right?
(If so is there some way to describe this better in the commit
message?)
Thanks,
Ben.
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
